From a650657a8da19b774f13c29bfed443ada5fd1eb0 Mon Sep 17 00:00:00 2001 From: mfadiln2018 Date: Tue, 6 Sep 2022 12:57:57 +0700 Subject: [PATCH 1/2] fix: delete unused code at callback order failed --- src/transaction/transaction.service.ts | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/transaction/transaction.service.ts b/src/transaction/transaction.service.ts index 332f73e..8da0a59 100644 --- a/src/transaction/transaction.service.ts +++ b/src/transaction/transaction.service.ts @@ -1229,10 +1229,6 @@ export class TransactionService { // const dataMsg = callback.msg; // const failedReason = dataMsg.split('.'); - // dataTransaction.status = statusTransaction.FAILED; - // dataTransaction.callback_json = callback; - // dataTransaction.failed_reason = `Trx ${product.code} ke ${dataTransaction.destination} gagal`; - const userData = await this.userService.findExist(dataTransaction.user); const product_price = await this.productHistoryPriceService.findById( @@ -1243,10 +1239,6 @@ export class TransactionService { product_price.product.id, ); - dataTransaction.status = statusTransaction.FAILED; - dataTransaction.callback_json = callback; - dataTransaction.failed_reason = `Trx ${product.code} ke ${dataTransaction.destination} gagal`; - console.log("inipricetable", dataTransaction.product_price.price) console.log("inipricecallback", callback['price']) if(callback['message']) { From 606864ec3b595fdbb2f5550b4467bbf480e9b7c3 Mon Sep 17 00:00:00 2001 From: Fadli Date: Tue, 6 Sep 2022 13:14:50 +0700 Subject: [PATCH 2/2] revert back status failed --- src/transaction/transaction.service.ts | 44 +++++++++++++------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/src/transaction/transaction.service.ts b/src/transaction/transaction.service.ts index 8da0a59..5414418 100644 --- a/src/transaction/transaction.service.ts +++ b/src/transaction/transaction.service.ts @@ -1107,27 +1107,27 @@ export class TransactionService { async checkCallbackOrderFailed(supplier_trx_id: string, callback: any) { - const transactionData = await this.findDataTransactionBySupplierTrxId( - supplier_trx_id - ); - - if (transactionData.status == statusTransaction.FAILED) { - throw new HttpException( - { - statusCode: HttpStatus.BAD_REQUEST, - error: 'failed to update, the transaction already failed', - }, - HttpStatus.BAD_REQUEST, - ); - } else if (transactionData.status == statusTransaction.SUCCESS) { - throw new HttpException( - { - statusCode: HttpStatus.BAD_REQUEST, - error: 'failed to update, the transaction already success', - }, - HttpStatus.BAD_REQUEST, - ); - } else { + // const transactionData = await this.findDataTransactionBySupplierTrxId( + // supplier_trx_id + // ); + // + // if (transactionData.status == statusTransaction.FAILED) { + // throw new HttpException( + // { + // statusCode: HttpStatus.BAD_REQUEST, + // error: 'failed to update, the transaction already failed', + // }, + // HttpStatus.BAD_REQUEST, + // ); + // } else if (transactionData.status == statusTransaction.SUCCESS) { + // throw new HttpException( + // { + // statusCode: HttpStatus.BAD_REQUEST, + // error: 'failed to update, the transaction already success', + // }, + // HttpStatus.BAD_REQUEST, + // ); + // } else { const updateTransaction = await this.callbackOrderFailed( supplier_trx_id, callback, @@ -1142,7 +1142,7 @@ export class TransactionService { HttpStatus.BAD_REQUEST, ); - } + // } }